New gallery UI implementation #56
Conversation
| } | ||
|
|
||
| plugins { | ||
| id("org.gradle.toolchains.foojay-resolver-convention") version "0.9.0" |
There was a problem hiding this comment.
added for hot-reload on jvm/deskop: https://github.com/JetBrains/compose-hot-reload
...gradle-plugin/src/main/kotlin/org/jetbrains/compose/storytale/plugin/JsMultiplatformTasks.kt
Outdated
Show resolved
Hide resolved
...ery/src/commonMain/kotlin/org/jetbrains/compose/storytale/gallery/material3/FullStoryView.kt
Show resolved
Hide resolved
| @@ -0,0 +1,122 @@ | |||
| import org.jetbrains.compose.reload.ComposeHotRun | |||
There was a problem hiding this comment.
I have a small question related to this module. We have the example one, which contains an example of the demo. Was it intentional to create a new one instead of re-using the example?
There was a problem hiding this comment.
the existing example requires a publication of all the modules to mavenLocal.
It was more convenient to iterate and test the gallery changes without a publication.
The existing example module is still useful to test the integration of all modules - we have CI checks with it.
We have something similar is Compose Multiplatform too: a demo right in the core project - it uses project dependencies, and a set of side projects which integrate everyting as published module dependencies.
There was a problem hiding this comment.
In the future, we need to figure out how to organize the structure in the repo so that it does not confuse us or the new contributors.
.../runtime-api/src/commonMain/kotlin/org/jetbrains/compose/storytale/StoryParameterDelegate.kt
Outdated
Show resolved
Hide resolved
Highlights:
./gradlew :gallery-demo:wasmJsBrowserDevelopmentRun